Conversation
Contributor
|
See more at https://github.com/apify/apify-client-js/actions/runs/36116203177#summary-108010787689 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every method that takes
timeoutSecsnow also takessignal?: AbortSignal, and forwards it to each request it sends. Once the signal aborts, the request in flight ends, no retry or further poll follows, and the method rejects with the signal'sreason. The field sits onTimeoutOptions, socall(),waitForFinish()and the single-request methods all pick it up.getOrCreate()body take it out first.batchAddRequests()retries end early on abort.sleep(ms, signal)moved from the HTTP client intoutils.tsfor that.batchAddRequests()rejects on abort. Its catch otherwise reports the remaining requests as unprocessed and resolves.StreamedLogtakes asignal, whichcall()passes through. Without it,call()with the default log redirection hung after an abort until a quiet run printed its next line.Tests: a forwarding case for every method in the
client_timeoutstable, andabort_signal.test.ts, which drivescall(),waitForFinish()andbatchAddRequests()against a local server.Closes #1071
✍️ Drafted by Claude Code