Conversation
Contributor
|
See more at https://github.com/apify/apify-client-js/actions/runs/36115592996#summary-108008817971 |
Contributor
|
I thought we agreed not to do it for now: |
Contributor
Author
Ok, closing, and moving the issue to icebox |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the status-message half of run log redirection from the Python client (apify/apify-client-python#407, apify/apify-client-python#1036).
RunClient.getStatusMessageWatcher()returns aStatusMessageWatcherthat polls the run and logsStatus: <status>, Message: <message>whenever either changes. It stops by itself once the run reports a terminal status message.ActorClient.call()now runs it next to the streamed log, with the samelogoption. Both are built before either starts, as in apify/apify-client-python#1036.Where it differs from Python:
undefinedoutside Node.js, likegetStreamedLog(), socall()in a browser logs nothing new.stop({ waitSecs })keeps polling for the terminal status message for at mostwaitSecs. Python sleeps a fixed 6 seconds.call()passes 6 seconds, and only when the run finished. The platform marks a status message terminal only on abort or timeout, or when the Actor does, socall()can take up to 6 seconds longer than before.Closes #1031
✍️ Drafted by Claude Code