test: cover a pending stored request with a null handledAt - #1079
Merged
Merged
Conversation
vdusek
added
the
t-tooling
Contributor
|
See more at https://github.com/apify/apify-client-js/actions/runs/36111005853#summary-107994213544 |
janbuchar
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both points of #266 were fixed on
v3by #1016. The stored request type now hashandledAt?: Date | null, andid,uniqueKeyandurlare required.The other fields (
method,retryCount,userData,headers,loadedUrl) stay optional. The API validates a new request but doesn't fill in defaults, so a request added with onlyurlanduniqueKeycomes back without them.This PR adds a test for that case:
getRequest()gets a pending request with only the required fields andhandledAt: null, parses it, and typeshandledAtas nullable. Theget-requestmock route now usesresponseJsonMockso the test can override the response.Closes #266
✍️ Drafted by Claude Code