Skip to content

test: cover sending a Buffer Actor input as raw bytes - #1078

Merged
vdusek merged 1 commit into
v3from
fix/buffer-body-serialization
Sep 25, 2026
Merged

vdusek merged 1 commit into
v3from
fix/buffer-body-serialization

Conversation

@vdusek

@vdusek vdusek commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Adds a regression test for #277: start() with a Buffer input and contentType: 'application/json' sends the raw bytes, and the server gets the decoded JSON back.

The bug itself is already gone on v3. serializeBody() from #1058 passes binary and string bodies through before it reaches JSON.stringify, and axios no longer re-serializes strings since #1051 set transformRequest: []. With the Buffer branch disabled, the new test fails with the { type: 'Buffer', data: [...] } payload from the issue.

Closes #277

✍️ Drafted by Claude Code

@vdusek vdusek added the t-tooling Issues with this label are in the ownership of the tooling team. label Sep 25, 2026
@vdusek vdusek self-assigned this Sep 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ There are broken links in the documentation.

See more at https://github.com/apify/apify-client-js/actions/runs/36110964961#summary-107994094312

@vdusek
vdusek marked this pull request as ready for review September 25, 2026 08:13
@vdusek
vdusek requested a review from janbuchar September 25, 2026 08:13
@vdusek
vdusek merged commit 69b4ab6 into v3 Sep 25, 2026
8 checks passed
@vdusek
vdusek deleted the fix/buffer-body-serialization branch September 25, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants