Skip to content

fix: stop apify upgrade reporting success after a failed binary write - #1462

Draft
l2ysho wants to merge 1 commit into
masterfrom
claude/triage-issue-1460-e98515
Draft

l2ysho wants to merge 1 commit into
masterfrom
claude/triage-issue-1460-e98515

Conversation

@l2ysho

@l2ysho l2ysho commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Note

TL;DR: On Unix bundle installs, apify upgrade printed "Successfully upgraded" and exited 0 even when downloading or writing the new binary failed. Now it skips the success message and exits 1.

Closes #1460

What changed

  • handleUnixUpgrade returns Promise<boolean>. A failed download or write sets process.exitCode = 1 and returns false. The caller prints the success message only when the upgrade worked.
  • A write failure now stops the upgrade right away instead of moving on to the next asset.
  • New test/local/commands/upgrade.test.ts: success path, failed write (ETXTBSY), and failed download (404). Both failure tests fail on master and pass with this fix.

Notes for reviewers

🤖 Generated with Claude Code

On Unix bundle installs, a failed download or write printed an error,
then "Successfully upgraded" and exited 0. Return a result from
handleUnixUpgrade, skip the success message on failure, and exit 1.

Closes #1460

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@l2ysho l2ysho added bug Something isn't working. t-builders Issues owned by the Builders team. labels Sep 24, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working. t-builders Issues owned by the Builders team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

apify upgrade fails with ETXTBSY on Linux and still reports success

2 participants