Conversation
On Unix bundle installs, a failed download or write printed an error, then "Successfully upgraded" and exited 0. Return a result from handleUnixUpgrade, skip the success message on failure, and exit 1. Closes #1460 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
TL;DR: On Unix bundle installs,
apify upgradeprinted "Successfully upgraded" and exited 0 even when downloading or writing the new binary failed. Now it skips the success message and exits 1.Closes #1460
What changed
handleUnixUpgradereturnsPromise<boolean>. A failed download or write setsprocess.exitCode = 1and returnsfalse. The caller prints the success message only when the upgrade worked.test/local/commands/upgrade.test.ts: success path, failed write (ETXTBSY), and failed download (404). Both failure tests fail onmasterand pass with this fix.Notes for reviewers
curl -fsSL https://apify.com/install-cli.sh | bash.upgradestill exit 0 (invalid version, missing assets, npm/pnpm/brew fallback failure). I left them out to keep this diff small.🤖 Generated with Claude Code