[Console] Add missing RBAC checks on cluster and variable endpoints#4381
Open
shangeyao wants to merge 1 commit into
Open
[Console] Add missing RBAC checks on cluster and variable endpoints#4381shangeyao wants to merge 1 commit into
shangeyao wants to merge 1 commit into
Conversation
Protect Flink cluster lifecycle APIs with cluster:create/update permissions and variable list/code-check APIs with variable:view (and related) permissions. Closes apache#4380 Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@RequiresPermissionsto unprotectedFlinkClusterControllerendpoints (page,list,alive,get,start,shutdown,delete, etc.).@RequiresPermissions("variable:view")toVariableController.listand guardcheck/codewith variable permissions.Logical.ORon clusterlist/aliveso app create/edit flows (app:add/app:update) can still load cluster options.Closes #4380
Test plan
cluster:updatecannot start/shutdown/delete clustersapp:addcan still load cluster list in Flink app formvariable:viewcannot list variables by teamIdMade with Cursor