[Bug] Revert FlinkEnv config path persistence regression#4375
Open
michael1991 wants to merge 1 commit into
Open
[Bug] Revert FlinkEnv config path persistence regression#4375michael1991 wants to merge 1 commit into
michael1991 wants to merge 1 commit into
Conversation
This reverts commit 81b8161.
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What is the purpose of the change
This PR reverts the regression introduced by 81b8161 from v2.1.7.
That commit changed
FlinkEnv.doSetFlinkConf()to persist the absolute Flink config file path intot_flink_env.flink_conf.However, existing read paths still expect
flink_confto be compressed Base64 content and callDeflaterUtils.unzipString(...), for example:/flink/env/getFlinkEnv.convertFlinkYamlAsMap()FlinkEnvServiceImpl.getFlinkConfig(...)When
flink_confcontains a path such as:Brief change log
Verifying this change
Manually verified with Flink 1.20.5:
Does this pull request potentially affect one of the following parts