[SPARK-56796][UI] Fix sticky tooltips for Stage page additional metrics#55771
Open
XdithyX wants to merge 1 commit intoapache:masterfrom
Open
[SPARK-56796][UI] Fix sticky tooltips for Stage page additional metrics#55771XdithyX wants to merge 1 commit intoapache:masterfrom
XdithyX wants to merge 1 commit intoapache:masterfrom
Conversation
…r selecting Stage page checkboxes
Contributor
Author
|
Hi @sarutak Can you please have a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates the Stage page additional metrics tooltips to use
data-bs-trigger="hover"(SPARK-56796).The change is limited to the additional metrics checkbox options under
Show Additional Metrics, such asScheduler Delay,Task Deserialization Time,Getting Result Time, andPeak Execution Memory.Why are the changes needed?
Currently, after selecting one of the Stage page additional metrics checkboxes, the tooltip can remain visible even after the mouse leaves the option.
This happens because Bootstrap tooltips use the default
hover focustrigger. When a checkbox inside the tooltip target is clicked, focus can keep the tooltip active after mouseleave.For these checkbox options, the tooltip should only be shown while hovering.
Does this PR introduce any user-facing change?
Yes.
In the Stage page, tooltips for
Show Additional Metricscheckbox options now disappear when the mouse leaves the option after selecting it.How was this patch tested?
Manually tested in the Spark UI Stage page:
Show Additional Metrics.Was this patch authored or co-authored using generative AI tooling?
Yes. GPT 5.5 was used.
Before the fix
before.mov
After the fix
after.fix.mov