fix(grpc): support Go 1.25 and 1.26 plugin scenarios - #252
Open
loon-hejw wants to merge 5 commits into
Open
Conversation
wu-sheng
requested review from
Copilot and
mrproliu
and removed request for
Copilot
July 28, 2026 06:38
mrproliu
previously approved these changes
Jul 28, 2026
mrproliu
reviewed
Jul 28, 2026
mrproliu
left a comment
Contributor
There was a problem hiding this comment.
Please update the changes.md and support-plugins.md
Author
|
Addressed in commit
|
mrproliu
approved these changes
Jul 29, 2026
Author
|
The latest Plugin Tests / mysql (https://github.com/apache/skywalking-go/actions/runs/30410944583/job/90449826435) job failed while pulling the mysql:5.7 image from Docker Hub: read: connection reset by peer The failure occurred before the MySQL test scenario started, and the remaining plugin jobs were cancelled by matrix fail-fast. The main CI, Windows plugin tests, and E2E workflows passed. This appears to be a transient external network failure unrelated to this PR. Could someone with permission please rerun the failed workflow? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Go 1.25 and Go 1.26 can build the agent at
754482220284, but the existingplugin runner and gRPC instrumentation leave several compatibility gaps:
go mod tidycan rewrite a generated scenario module togo 1.25.0orgo 1.26.0while the generated workspace remains ongo 1.25orgo 1.26.*transport.ServerStreamto server internals. The current plugin asserts*transport.Stream, causing an intercepted panic and fragmented servertraces. Unary
SendResponsespans are also skipped for the new stream type.What changed
go.workaftergo mod tidy.MethodandContextcontract instead of a concrete internal type.
Validation
go test -race ./plugins/grpc/... ./test/plugins/runner-helper/... ./tools/go-agent/instrument/...go test ./...linux/arm64The baseline gRPC reproduction logs:
The process survives because the agent recovers the interceptor panic, but the
server streaming trace is split into orphan segments. Both patched Go versions
pass the strict scenario validator without the panic.