Skip to content

enh: rework form resubmit via self-dispatch rather than a network-call - #2900

Draft
lprimak wants to merge 4 commits into
apache:mainfrom
lprimak:remove-resubmit-netcall
Draft

lprimak wants to merge 4 commits into
apache:mainfrom
lprimak:remove-resubmit-netcall

Conversation

@lprimak

@lprimak lprimak commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • Committers: Make sure a milestone is set on the PR
  • Committers: Use "Squash and Merge" to combine all commits into one when merging a PR when appropriate.

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@github-actions github-actions Bot added java Pull requests that update Java code tests documentation labels Sep 29, 2026
@lprimak lprimak added this to the 3.0.2 milestone Sep 29, 2026
@lprimak lprimak self-assigned this Sep 29, 2026
@github-actions github-actions Bot added the xml label Sep 29, 2026
@lprimak

lprimak commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor Author

For now, this is full of AI slop, but it (at least tests pass) works?. Needs lots of refactoring and simplification, so the code actually makes some sense

Comment thread support/jakarta-ee/src/test/java/org/apache/shiro/ee/filters/FormDispatchTest.java Dismissed
Comment thread support/jakarta-ee/src/test/java/org/apache/shiro/ee/filters/FormDispatchTest.java Dismissed
Comment thread support/jakarta-ee/src/test/java/org/apache/shiro/ee/filters/FormDispatchTest.java Dismissed
Comment thread support/jakarta-ee/src/test/java/org/apache/shiro/ee/filters/FormDispatchTest.java Dismissed
Comment thread support/jakarta-ee/src/test/java/org/apache/shiro/ee/filters/FormDispatchTest.java Dismissed
Comment thread support/jakarta-ee/src/test/java/org/apache/shiro/ee/filters/FormDispatchTest.java Dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation java Pull requests that update Java code tests xml

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants