chore: Generate SBOM files with CycloneDX and SPDX maven plugins - #2893
Merged
Merged
Conversation
lprimak
requested review from
bmarwell,
boris-petrov,
fpapon,
jbonofre and
steinarb
September 18, 2026 21:34
steinarb
approved these changes
Sep 19, 2026
steinarb
left a comment
Contributor
There was a problem hiding this comment.
(I guess this was explained when I was curious about where the BOM went.
But from googling the concepts I see that both CycloneDN and SPDX are stuff I should look into privately...?)
Anyway: LGTM
Contributor
Author
|
Thanks Steinar. Sounds similar to maven BOM but they are not. Maven BOM is no longer necessary in 3.x because it was only used for Jakarta classifier which is no longer used in 3.x |
Contributor
|
>>>> Lenny Primak ***@***.***>:
SBOM files are part of the EU CRA requirements and can help figure out the vulnerabilities of the software.
Thanks! Will read up.
Sounds similar to maven BOM but they are not. Maven BOM is no longer necessary in 3.x because it was only used for Jakarta classifier which is no longer used in 3.x
Yes, I thought remembered something about that from the 3.0 code review.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
[#XXX] - Fixes bug in SessionManager,where you replace
#XXXwith the appropriate GitHub issue. Best practiceis to use the GitHub issue title in the pull request title and in the first line of the commit message.
fixes #XXXif merging the PR should close a related issue.mvn verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like
[DOC] - Add javadoc in SessionManager.If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.