[fix][build] Quote protobuf stub script paths#25834
Closed
hiSandog wants to merge 1 commit into
Closed
Conversation
Member
This script is rarely used by Pulsar developers. It's uncommon to put spaces or shell metacharacters in development environment directory names. Just wondering the motivation for this PR. AI scans over the repository files could find multiple similar issues with development scripts which are intended only for Pulsar developers. |
Member
|
This script is intended to be run inside docker with the https://github.com/apache/pulsar/blob/master/src/update_python_protobuf_stubs_with_docker.sh script. The changes in this PR doesn't have an impact on the way it's used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Python protobuf stub generation script uses a temporary virtualenv path and its own script directory in several shell commands. Leaving those paths unquoted can split paths that contain spaces or other shell metacharacters, and it also makes the cleanup command less robust.
Modifications
Quote the temporary virtualenv path and script directory references in src/update_python_protobuf_stubs.sh.
Verifications