[core] Implement withFilter for PartitionsTable and FilesTable#7791
Open
heye1005 wants to merge 1 commit intoapache:masterfrom
Open
[core] Implement withFilter for PartitionsTable and FilesTable#7791heye1005 wants to merge 1 commit intoapache:masterfrom
heye1005 wants to merge 1 commit intoapache:masterfrom
Conversation
heye1005
force-pushed
the
system-tables-with-filter-postfilter
branch
from
df543e9 to
e97a299
Compare
Replace the placeholder TODO in PartitionsRead.withFilter and FilesRead.withFilter with a post-filter that evaluates the predicate on the materialized row before projection. For FilesRead, partition / bucket / level are stripped out because they are already pushed down by FilesScan; re-evaluating them on the materialized row would compare values of incompatible representations (e.g. a String literal vs the BinaryString in the row). Adds tests covering equal / in / range / combined pushdown + post-filter scenarios for both system tables.
heye1005
force-pushed
the
system-tables-with-filter-postfilter
branch
from
e97a299 to
028e584
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #7792
Purpose
Implement
PartitionsRead.withFilterandFilesRead.withFilter, which werepreviously no-op stubs marked
// TODO. Predicates are now applied as apost-filter on the materialized row, so
WHEREclauses on these system tablestake effect at the source level.
For
FilesRead, predicates onpartition,bucketandlevelare excludedfrom the post-filter because they are already handled by
FilesScan.Tests
Added unit tests for equal / in / range / combined pushdown + post-filter
scenarios in
PartitionsTableTestandFilesTableTest. All existingsystem-table tests pass.