feat(services): retry HTTP 429 responses - #8035
Merged
Merged
Conversation
ddupg
marked this pull request as ready for review
August 7, 2026 09:55
erickguan
self-requested a review
August 7, 2026 13:22
erickguan
approved these changes
Aug 7, 2026
erickguan
left a comment
Member
There was a problem hiding this comment.
Thank you! Great improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A. This is a small consistency improvement across service error parsers.
Rationale for this change
RetryLayerretries only errors marked as temporary. Azure Blob, Azure Data Lake Storage, OSS, and Hugging Face currently classify HTTP 429 responses as persistentUnexpectederrors, soRetryLayerdoes not retry them.The retry behavior is supported by the providers' official SDKs or documentation:
BlobClientOptions. Azure Data Lake clients inherit the Azure Core retry options: Azure SDK retry policy and DataLakeClientOptions.429 // Rate exceededin its retryable error codes: retryable_error.go.This PR intentionally leaves Tencent COS unchanged. The official COS documentation describes QPS limits and flow control but does not document that they return HTTP 429, and the official Go SDK retry tests cover 500, 503, and 504 but not 429: COS request rate limits and COS Go SDK retry tests.
What changes are included in this PR?
ErrorKind::RateLimitedin the Azure Blob, Azure Data Lake Storage, OSS, and Hugging Face error parsers.Retry-Afterhandling unchanged.Validation:
cargo fmt --all -- --check-D warningsAre there any user-facing changes?
Yes. When users wrap these services with
RetryLayer, HTTP 429 responses now enter the configured retry flow. There are no public API changes.AI Usage Statement
OpenAI Codex (GPT-5) was used to investigate provider retry behavior, implement the change, and run validation.