fix(services/github): support env-driven construction via from_uri - #8009
Closed
trim21 wants to merge 1 commit into
Closed
fix(services/github): support env-driven construction via from_uri#8009trim21 wants to merge 1 commit into
trim21 wants to merge 1 commit into
Conversation
dosubot
Bot
added
the
size:M
trim21
changed the title
trim21
marked this pull request as draft
August 1, 2026 15:26
GithubConfig::from_uri requires owner and repo to be parsed from the URI
authority, which breaks Operator::via_iter("github", env) construction
used by the behavior tests and env-driven setups. Fall back to options
when the URI has no authority or path.
trim21
force-pushed
the
fix-github-env-construction
branch
from
August 1, 2026 15:27
fcb5d73 to
4d14e94
Compare
Contributor
Author
|
Merged into #8010 per review discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None.
Rationale for this change
GithubConfig::from_urirequiresownerandrepoto be parsed from the URI authority, which breaksOperator::via_iter("github", ...)construction used by env-driven setups and the behavior test framework. The github service is the only service that cannot be configured through environment variables.What changes are included in this PR?
OPENDAL_GITHUB_OWNER/OPENDAL_GITHUB_REPO) when the URI has no authority or path;github://<owner>/<repo>/<root>URI semantics are unchanged.#[serde(default)]would otherwise silently turn a missing field into an empty string.Are there any user-facing changes?
OPENDAL_GITHUB_OWNER/OPENDAL_GITHUB_REPOenvironment variables now work for configuring the github service.