Fixed: updatePartyRate does not persist expiry of the previous rate (OFBIZ-13590) - #2012
Merged
Merged
Conversation
…OFBIZ-13590) - The method set partyRate.thruDate = UtilDateTime.nowTimestamp() to expire the previously active PartyRate but never called .store(), so the mutation only existed in memory and was discarded; multiple "active" PartyRate rows accumulated for the same party/rateType since none of the earlier ones actually got expired - The lookup for that previous PartyRate was also missing filterByDate() (present in the original minilang), so getFirst() could pick an already-expired row instead of the currently active one to expire Both fixes were verified against the original minilang and covered by a temporary RED/GREEN test before removal, and the accounting component's rate test suite passes unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both fixes were verified against the original minilang and covered by a temporary RED/GREEN test before removal, and the accounting component's rate test suite passes unchanged.