Fixed: Two regressions in the minilang-to-Groovy conversion of ContentServicesScript.groovy (OFBIZ-13589) - #2008
Merged
Conversation
…tServicesScript.groovy (OFBIZ-13589) - copyContentAndElectronicTextandAssoc assigned content directly from a cached view (ContentWorker.getContentCache()) and then mutated it in place to build the copy, silently corrupting the shared, cached ContentDataResourceView entry for the original contentId; the original minilang cloned the value before mutating, and this restores that clone - createMissingContentAltUrls's WebSiteContent lookup was missing a filterByDate() the original minilang had, so expired associations were also processed (over-processing only, no data loss) Both fixes were verified against the original minilang and covered by a temporary RED/GREEN test before removal, and the content component's test suite passes unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both fixes were verified against the original minilang and covered by a temporary RED/GREEN test before removal, and the content component's test suite passes unchanged.