Fixed: createUpdateBillingAddressAndPaymentMethod throws NPE for anonymous checkout (OFBIZ-13584) - #2005
Merged
Conversation
…ymous checkout (OFBIZ-13584) The method dereferenced userLogin.userLoginId without checking userLogin for null first, throwing a NullPointerException whenever a partyId is present but the shopping cart has no associated userLogin (an anonymous checkout carrying a resolved party from elsewhere). The original minilang's dotted-field access degraded gracefully to null in that case instead of crashing. The guard now checks userLogin is non-null before accessing userLoginId, matching the pattern already used in the sibling method createUpdateCustomerAndShippingAddress in the same file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method dereferenced userLogin.userLoginId without checking userLogin for null first, throwing a NullPointerException whenever a partyId is present but the shopping cart has no associated userLogin (an anonymous checkout carrying a resolved party from elsewhere). The original minilang's dotted-field access degraded gracefully to null in that case instead of crashing. The guard now checks userLogin is non-null before accessing userLoginId, matching the pattern already used in the sibling method createUpdateCustomerAndShippingAddress in the same file.