Fixed: Two regressions in the minilang-to-Groovy conversion of CommonServicesScript.groovy (OFBIZ-13583) - #2003
Merged
Conversation
…ServicesScript.groovy (OFBIZ-13583) - convertUom's guard `if (parameters.originalValue && uomConversion.conversionFactor)` treated numeric 0 as falsy, skipping the multiplication and returning convertedValue: null instead of 0 for a zero originalValue, risking NPEs in downstream code expecting a BigDecimal - getVisualThemeResources's fallback read the theme id via plain UtilProperties.getPropertyValue, which only checks general.properties; switched to EntityUtilProperties.getPropertyValue so it also honors a general/VISUAL_THEME SystemProperty override, matching the convention already used for this exact property in CmsEvents.java and DataResourceWorker.java (the original minilang hardcoded a literal FLAT_GREY here, but that theme currently has no VisualThemeResource seed data of its own, so a literal revert would leave the fallback permanently broken; this instead keeps the property-based fallback but makes it consistent with how the rest of the codebase reads this property) Both fixes were verified against the original minilang and current codebase conventions, and covered by a temporary RED/GREEN test before removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if (parameters.originalValue && uomConversion.conversionFactor)treated numeric 0 as falsy, skipping the multiplication and returning convertedValue: null instead of 0 for a zero originalValue, risking NPEs in downstream code expecting a BigDecimalBoth fixes were verified against the original minilang and current codebase conventions, and covered by a temporary RED/GREEN test before removal.