games/brickmatch: Add touchscreen input and module support. - #3662
Open
aviralgarg05 wants to merge 1 commit into
Open
games/brickmatch: Add touchscreen input and module support.#3662aviralgarg05 wants to merge 1 commit into
aviralgarg05 wants to merge 1 commit into
Conversation
6 tasks
Contributor
|
@aviralgarg05 the PR is about adding touchscreen to brickmatch, but you are adding a Calculator here. All PRs needs to have logical separation |
Contributor
Author
Sorry, will check and fix all the PRs |
aviralgarg05
force-pushed
the
gsoc/brickmatch-touch-input-pr12
branch
from
August 14, 2026 15:11
5e09f0b to
6420d2a
Compare
aviralgarg05
marked this pull request as ready for review
August 14, 2026 15:14
aviralgarg05
force-pushed
the
gsoc/brickmatch-touch-input-pr12
branch
from
August 15, 2026 10:02
4da00cf to
07e5237
Compare
Contributor
Author
|
Fixed the PR |
aviralgarg05
force-pushed
the
gsoc/brickmatch-touch-input-pr12
branch
from
August 15, 2026 11:03
89fb5f8 to
4d88eaf
Compare
xiaoxiang781216
approved these changes
Aug 15, 2026
Route touch presses through BrickMatch's input layer and allow the game to build as a module. Signed-off-by: aviralgarg05 <gargaviral99@gmail.com>
aviralgarg05
force-pushed
the
gsoc/brickmatch-touch-input-pr12
branch
from
August 16, 2026 15:31
4d88eaf to
55fbf8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
brickmatch could only be played with a keyboard, so on a board whose only
input is a touchscreen it could be started but not actually played.
This reads the touchscreen through the same input abstraction the existing
key handling uses, so the game loop is unchanged: a press maps to the
paddle position, and the existing key path stays as it is for boards with a
keyboard. The Kconfig entry also becomes tristate so the game can be built
as a loadable module rather than only into the image.
The diff previously carried the commits it was branched from, which is why
it showed a calculator that has nothing to do with brickmatch. It now
contains only the brickmatch change.
Impact
Testing
Build host: macOS 26.5, arm64,
xtensa-esp-elf-gcc 14.2.0(
esp-14.2.0_20251107).Target: Xtensa / ESP32-S3, Waveshare ESP32-S3-Touch-LCD-7, 800x480 RGB565
framebuffer with a GT911 touchscreen.
nxstyle,tools/checkpatch.sh,codespellandgit diff --checkthe game runs to a win and a loss without the keyboard attached
PR verification Self-Check