Moduleloading: Fix loading of classes in packages only present as versioned entries#9396
Open
matthiasblaesing wants to merge 2 commits into
Open
Moduleloading: Fix loading of classes in packages only present as versioned entries#9396matthiasblaesing wants to merge 2 commits into
matthiasblaesing wants to merge 2 commits into
Conversation
- General cleanups - JarClassLoader#addURL is unused - JarClassLoader#getClassData is unused - Archive#isActive is unused
…sioned entries The NetBeans classloader infrastructure relies on a mapping of packages classloaders can load resources/classes from. That mapping is currently not scanning META-INF/versions/<version> for packages. This becomes a problem if the versioned folder contains packages not present in the non-versioned part of the JAR. This change adds coverage for the versioned folder. Closes: apache#9371
matthiasblaesing
force-pushed
the
versioned_jarfile_packages
branch
from
8d8e8d7 to
fc5f876
Compare
matthiasblaesing
added
Platform
Member
|
have you tried: -> and checked if the packages show up automatically when the jdk api is used? This will open the jar in multi release mode, default is jdk8 mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NetBeans classloader infrastructure relies on a mapping of packages
classloaders can load resources/classes from. That mapping is currently
not scanning META-INF/versions/ for packages. This becomes a
problem if the versioned folder contains packages not present in the
non-versioned part of the JAR.
This change adds coverage for the versioned folder.
Closes: #9371