fix(bitbucket): tolerate null datacenter comment replies#792
Merged
Conversation
Contributor
Author
|
Hi @potiuk, this is a quick follow-up fix for the non-blocking robustness suggestion left after the previous Bitbucket discussion PR was merged. It only hardens _datacenter_comment_tree for the comments: null case and adds a regression test for it. If this looks good, I’d appreciate a quick review/merge so I can move on to the next Bitbucket implementation. Thanks again. |
potiuk
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
comments: nullvalue.comment.commentsfields as no replies by usingraw.get("comments") or [].comments: nullcase so the discussion normalizer does not crash on this payload shape.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-filespassesuv run pytest/ruff check/mypypasses(
PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
PYTHONPATH=src uv run --group dev pytest tests/test_bitbucket.pyRFC-AI-0004 compliance
contract:change-request/ partial read-only path without adding new Bitbucket-specific capability prose.Linked issues
Refs #606
Notes for reviewers
This follows up on the non-blocking robustness note from the merged Bitbucket discussion PR.
Bitbucket Data Center nested replies are already flattened through
_datacenter_comment_tree; this PR only hardens that path for payloads where the API returns"comments": nullinstead of omitting the field or returning an empty list.The behaviour is unchanged for normal threaded replies.