docs(atr-runbook): correct the atr client commands (start/upload/check/vote)#791
Merged
Conversation
…k/vote) The ATR runbook's Compose/Vote commands were placeholders that no longer match the atr client. Per the client's COMMANDS.md: release drafts are 'atr release start PROJECT VERSION' (revision-based, no --rc), files upload one-per-call via top-level 'atr upload PROJECT VERSION PATH FILEPATH', checks are 'atr check status/blockers …', and the vote is 'atr vote start PROJECT VERSION REVISION -m LIST --duration …'. Update Steps C and D accordingly.
… on vote start Follow-up corrections: the revision id is listed by 'atr revisions PROJECT VERSION' (not 'atr check status'); and when 'atr check concerns' surfaces non-blocking concerns, start the vote with the concerns-noted flag so they are acknowledged in the thread. Adds 'atr revisions' + 'atr check concerns' to the Compose poll block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ATR runbook's Compose (Step C) and Vote (Step D) command blocks were placeholders that don't match the actual
atrclient — they usedatr release create … --rc,atr release upload, andatr checks list, none of which exist. Corrected against the client'sCOMMANDS.md:atr release create magpie <v> --rc <rc>atr release start magpie <v>— revision-based, no--rcatr release upload magpie <v> <files…>atr upload magpie <v> PATH FILEPATH— top-level, one file per callatr checks list magpie <v>atr check status magpie <v> --verbose(+atr check blockers … <revision>)atr vote start magpie <v> <revision> -m dev@… --duration 72 --subject …Discovered while running the ATR path for the 0.1.0 release:
atr release create/atr release uploaderrored, and the client uses revisions rather than rc-numbers.Notes
docs/release-management/atr-release-runbook.md(Steps C + D).atr <cmd> --helpto confirm flags" caveat.🤖 Generated with Claude Code