feat(release): make the RC-tag push remote configurable via git_upstream_remote#788
Merged
Merged
Conversation
…eam_remote release-rc-cut hardcoded the tag push to a substitute-it-yourself `<upstream-remote>` placeholder defaulting to `origin`, so an RM whose upstream remote is named `upstream` or `apache` had to hand-edit every emitted recipe. Add a `git_upstream_remote` config key that release-rc-cut resolves to emit the concrete remote name, plus a `--remote` per-invocation override. Set to `upstream` in Magpie's own config; default `origin` in the adopter template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-rc-cutemitted the RC-tag push asgit push <upstream-remote> …with<upstream-remote>defaulting tooriginand a note telling the RM to substitute it. An RM whose local remote for the upstream repo is namedupstreamorapache(notorigin) had to hand-edit every emitted recipe. This adds agit_upstream_remoteconfig key thatrelease-rc-cutresolves so it emits the concrete remote name, plus a--remoteper-invocation override.Changes
projects/_template/release-management-config.md— newgit_upstream_remotekey (defaultorigin) + note on typical values (origin,upstream,apache).projects/magpie/release-management-config.md— setgit_upstream_remote: upstream(Magpie's checkout uses theupstreamremote forapache/magpie).skills/release-rc-cut/SKILL.md— read the key in Step 1 (config table + JSON), add the--remoteinput, and emit the resolved concrete remote in the tag-push command. Trimmed a note to keep SKILL.md ≤500 lines.Only
release-rc-cutamong the 10 release skills references a git remote name (the rest use svn/gh/aws), so no other skill changes were needed.Test plan
skill-and-tool-validatepasses (no new warnings; SKILL.md at 499 lines).git_upstream_remoteunset — still defaults toorigin.🤖 Generated with Claude Code