Add an annotation framework for typed table properties by blackmwk · Pull Request #2955 · apache/iceberg-rust

blackmwk · 2026-08-04T09:29:10Z

Which issue does this PR close?

Closes Type safe TableProperties parsing. #2877.

What changes are included in this PR?

Add the iceberg-property-macro crate with a Properties derive macro.
Define table-property keys, defaults, documentation, and custom converters using field annotations.
Generate Default, public getters, string-map parsing, and JSON serialization/deserialization.
Keep TableProperties fields private.
Change write.format.default from String to the typed DataFileFormat.
Update existing consumers to use the generated getters.
Update the public API snapshot.

Are these changes tested?

Yes.

Added unit tests for default and overridden property values.
Added JSON serialization and deserialization round-trip tests.
Added coverage for optional properties and custom parsing behavior.
Ran the Iceberg and DataFusion unit test suites.
Ran Clippy with warnings denied.
Verified formatting and the public API snapshot.

blackmwk · 2026-08-05T08:04:10Z

+        };
+
+        let json = serde_json::to_value(&properties).unwrap();
+        let expected_parts = [


This is incorrect. I expect that if the value is same as default, we skip when serializing.

Property framework for iceberg

f8043dd

blackmwk force-pushed the ir-2877 branch from 938d5bd to f8043dd Compare August 4, 2026 09:37

blackmwk commented Aug 4, 2026

View reviewed changes

Comment thread crates/property-macro/src/lib.rs Outdated

Comment thread crates/iceberg/src/spec/table_properties.rs Outdated

Comment thread crates/iceberg/src/spec/table_properties.rs

Comment thread crates/iceberg/src/spec/table_properties.rs

blackmwk marked this pull request as draft August 4, 2026 09:49

blackmwk added 4 commits August 4, 2026 20:34

Address comments

d7f7def

Address comments

5bfe098

PUb fields

80d19aa

No nested

389c8ef