Repository navigation
Add rename_view to REST Catalog - #4081
Open
rambleraptor wants to merge 7 commits into
Open
rambleraptor wants to merge 7 commits into
rambleraptor wants to merge 7 commits into
Conversation
- Add @OverRide to RestCatalog/SqlCatalog rename_view and restore it on BigQueryMetastoreCatalog.load_namespace_properties - Split identifiers once in RestCatalog.rename_view - Fix "fully classified" typo in the Catalog.rename_view docstring - Add a cross-namespace rename integration test - Drop a stale skip on test_rest_custom_namespace_separator reintroduced by rebase Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rambleraptor
requested review from
Fokko,
geruh and
kevinjqliu
and removed request for
Fokko,
geruh and
kevinjqliu
October 5, 2026 19:15
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
I'm reviving #2149, which was closed for being stale. I addressed the comments on that PR. This is the last thing we need to have complete view support.
Are these changes tested?
Yes. Unit tests in
tests/catalog/test_rest.pyand integration tests intests/integration/test_catalog.py.Are there any user-facing changes?
rename_viewsupport to the Iceberg REST Catalog.cc @ebyhr @kevinjqliu @abnobdoss @jayceslesar @nhuantho, who reviewed #2149
AI Disclosure: Claude double checked the old PR and made sure the comments were all addressed.