Skip to content

refactor: simplify CLI property lookup - #3750

Open
mj006648 wants to merge 1 commit into
apache:mainfrom
mj006648:refactor/cli-property-lookup
Open

refactor: simplify CLI property lookup#3750
mj006648 wants to merge 1 commit into
apache:mainfrom
mj006648:refactor/cli-property-lookup

Conversation

@mj006648

@mj006648 mj006648 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

This is a follow-up to the review suggestion in #3745. The table and namespace property lookup paths can be flattened with early returns, making the success path easier to read without changing behavior.

This applies the same structure to both commands:

  • return after describing all properties when no property name is provided
  • raise immediately when a requested property is missing
  • write the property value at the end

Are these changes tested?

Yes. Added regression coverage for a missing namespace property and ran:

  • make lint
  • uv run python -m pytest tests/cli/test_console.py

Are there any user-facing changes?

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant