mod_http2: preserve response metadata lifetime - #708
Open
carrerasdarren-cell wants to merge 1 commit into
Open
Conversation
Copy response and trailer metadata into the stream pool before destroying their buckets. Otherwise the retained pointers reference nodes returned to the APR bucket allocator. Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
h2_headerspath unchangedRoot cause
With response buckets enabled,
stream_do_response()retainedb->data, destroyedb, and later stored that pointer instream->response. Destroying the bucketreturns its
ap_bucket_responsewrapper to the APR bucket allocator, so latersmall bucket allocations can overwrite the retained response status and table
pointers.
stream_do_trailers()had the same lifetime mismatch for itsap_bucket_headerswrapper.The tables and strings already live in the stream pool. Copying the small wrapper
before bucket destruction gives the retained metadata the same lifetime.
Validation
mod_http2andmod_proxy_http2response trailers, and server push
allocation reuses and overwrites the freed response-wrapper address
Assisted-by: OpenAI Codex