HADOOP-19930. ObjectWritable to validate class on load - #8569
Closed
steveloughran wants to merge 1 commit into
Closed
HADOOP-19930. ObjectWritable to validate class on load#8569steveloughran wants to merge 1 commit into
steveloughran wants to merge 1 commit into
Conversation
steveloughran
force-pushed
the
pr/HADOOP-19864-writable-load
branch
from
June 29, 2026 13:41
9cd5316 to
ecdaf1c
Compare
steveloughran
changed the title
|
💔 -1 overall
This message was automatically generated. |
steveloughran
force-pushed
the
pr/HADOOP-19864-writable-load
branch
from
June 29, 2026 16:41
d801691 to
2513bb6
Compare
steveloughran
force-pushed
the
pr/HADOOP-19864-writable-load
branch
from
July 9, 2026 18:03
fea4ff2 to
9861bbb
Compare
New reflection validation in ReflectionUtils -Pulls up class type checking to before actual class load; fails fast -Add check of array length. -Limit recursive depth to 100. +Sequence file logic. Conf loading does force classloading, so move sequence file logic out of it. This does remove it from the conf file weak hash map of classes, but the jvm does its own class map here. The real feature of the conf map is the caching of cache misses, which would actually surface as errors on reading files, so you aren't saving anything performance-wise. Contains content generated by Claude.ai Contributed by Steve Loughran. # Conflicts: # hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFile.java
steveloughran
force-pushed
the
pr/HADOOP-19864-writable-load
branch
from
July 28, 2026 18:56
f1e4189 to
df7fca6
Compare
6 tasks
Contributor
Author
|
superceded by #8640 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls up class type checking to before actual class load; fails faster.
-Add check of array length.
-Limit recursive depth to 100.
Choice of depth is completely random; FWIW jackson has a limit of 1000.
How was this patch tested?
New tests
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html