[VL] Update for CI image build with recent workaround#12322
Merged
Conversation
Signed-off-by: Yuan <yuanzhou@apache.org>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Gluten’s Velox CI Docker image build inputs to incorporate a recent workaround, primarily by adjusting CentOS-based static-build images to use a pinned CMake version and applying a CentOS7 header workaround.
Changes:
- Pin CMake installation to
cmake==3.31.4in CentOS8/CentOS9 static-build Dockerfiles (and the CentOS8 GCC13 variant). - Add a CentOS7 GCC13 static-build workaround by copying a
socket.hheader into the system include path. - Add
perl-FindBinto the CentOS9 static-build toolchain install list.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| dev/docker/Dockerfile.centos9-static-build | Adds perl-FindBin and installs pinned CMake via pip. |
| dev/docker/Dockerfile.centos8-static-build | Installs pinned CMake via pip for CentOS8 static build. |
| dev/docker/Dockerfile.centos8-gcc13-static-build | Pins CMake installation version via pip3. |
| dev/docker/Dockerfile.centos7-gcc13-static-build | Adds a header-copy workaround before running vcpkg setup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+29
to
+30
| dnf install -y --setopt=install_weak_deps=False gcc-toolset-12 gcc-toolset-13 perl-FindBin; \ | ||
| pip install cmake==3.31.4; \ |
Comment on lines
31
to
+32
| dnf install -y --setopt=install_weak_deps=False gcc-toolset-11; \ | ||
| pip install cmake==3.31.4; \ |
| dnf -y --enablerepo=powertools install autoconf-archive ninja-build; \ | ||
| pip3 install --upgrade pip; \ | ||
| pip3 install cmake; \ | ||
| pip3 install cmake==3.31.4; \ |
marin-ma
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
need to add changes from
3a13aef
How was this patch tested?
pass GHA
Was this patch authored or co-authored using generative AI tooling?