Skip to content

fix(map): support dataset with seriesLayoutBy row in map series #21767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jayzhou2309 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(map): support dataset with seriesLayoutBy row in map series #21767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00ee0a8
test(map): cover map series dataset layouts with missing regions
jayzhou2309 Sep 28, 2026
99b0b96
fix(map): support dataset with seriesLayoutBy row in map series. clos…
jayzhou2309 Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/chart/map/MapSeries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ import {
CallbackDataParams,
ComponentOnCalendarOptionMixin,
ComponentOnMatrixOptionMixin,
RoamHostModel
RoamHostModel,
SOURCE_FORMAT_ORIGINAL
} from '../../util/types';
import { Dictionary, NullUndefined } from 'zrender/src/core/types';
import GeoModel, { GeoCommonOptionMixin, GeoItemStyleOption } from '../../coord/geo/GeoModel';
Expand Down Expand Up @@ -165,7 +166,14 @@ class MapSeries extends SeriesModel<MapSeriesOption> implements RoamHostModel {
// Complete data with missing regions. The consequent processes (like visual
// map and render) can not be performed without a "full data". For example,
// find `dataIndex` by name.
data.appendData(toAppendItems);
if (this.getSource().sourceFormat === SOURCE_FORMAT_ORIGINAL) {
data.appendData(toAppendItems);
}
else {
// A dataset can not hold `{name}` items, and `seriesLayoutBy: 'row'`
// can not be appended at all, so only add names to the store.
data.appendValues([], zrUtil.map(toAppendItems, item => item.name as string));
}

return data;
}
Expand Down
85 changes: 85 additions & 0 deletions test/ut/spec/series/map.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.