Conversation
…1346 Signed-off-by: Jake Wang <jakezwang@users.noreply.github.com>
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
What does this PR do?
Honor
brush.brushMode: 'multiple'when first activating a toolbox brush tool.Fixed issues
Fixes #21346.
Details
Before: What was the problem?
The toolbox only reads
brushModel.brushOption.brushMode, which is unset before the first brush action. It falls back tosingleeven when the brush component is configured for multiple selections; the Keep selection icon also starts in the wrong state.After: How does it behave after the fixing?
Fall back to the component's configured
brushModebefore the defaultsingle. Explicit mode changes through Keep selection still take precedence.Document Info
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
test/brush3.html.TZ=UTC npm test -- --runInBand --coverage=false: 27 suites / 197 tests passed.npm run build:lib,npm run checktype,npm run lint, andnode build/build.js --type all: passed. Generated build output is not included.Merging options
Other information
Implementation and validation were performed primarily with OpenAI Codex.