[Improvement-18593] [API&DAO] Optimize TaskInstanceMapper to exclude large text fields from list queries - #18595
[Improvement-18593] [API&DAO] Optimize TaskInstanceMapper to exclude large text fields from list queries#18595njnu-seafish wants to merge 4 commits into
Conversation
ruanwenjun
left a comment
There was a problem hiding this comment.
Please provide benchmark results to show exactly how much performance this type of refactoring can improve. Otherwise, we should return all fields in Listing interface, rather than add new VO/DTO.
|
|
||
| private int pid; | ||
|
|
||
| private String appLink; |
There was a problem hiding this comment.
Remove the text column at listing api.
There was a problem hiding this comment.
Remove the text column at listing api.
Sorry, I'm not quite sure I understand this review comment. I've already run the SQL benchmark with large fields excluded.
|
@ruanwenjun When you have a moment, could you please review the code again? Thanks so much! |
|
This E2E test failure appears to be unrelated to the changes in this PR.
|



Was this PR generated or assisted by AI?
YES. Leverage LLMs to verify that the removed large text fields are indeed unused.
Purpose of the pull request
close #18593
Brief change log
Optimize TaskInstanceMapper to exclude large text fields from list queries
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md