Skip to content

fix: return error instead of panic when decoding ParquetScan/AvroScan without features #24198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumarUjjawal merged 1 commit into from
Aug 9, 2026
Merged

fix: return error instead of panic when decoding ParquetScan/AvroScan without features #24198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions datafusion/proto/src/physical_plan/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1086,8 +1086,8 @@ pub trait PhysicalPlanNodeExt: Sized {
ParquetSource::try_from_proto(self.node(), &decode_ctx)
}
#[cfg(not(feature = "parquet"))]
panic!(
"Unable to process a Parquet PhysicalPlan when `parquet` feature is not enabled"
not_impl_err!(
"Unable to process a Parquet PhysicalPlan when the `parquet` feature is not enabled"
)
}
PhysicalPlanType::AvroScan(scan) => {
Expand Down Expand Up @@ -1423,8 +1423,8 @@ pub trait PhysicalPlanNodeExt: Sized {
}

#[cfg(not(feature = "parquet"))]
panic!(
"Unable to process a Parquet PhysicalPlan when `parquet` feature is not enabled"
not_impl_err!(
"Unable to process a Parquet PhysicalPlan when the `parquet` feature is not enabled"
)
}

Expand All @@ -1449,7 +1449,9 @@ pub trait PhysicalPlanNodeExt: Sized {
}

#[cfg(not(feature = "avro"))]
panic!("Unable to process a Avro PhysicalPlan when `avro` feature is not enabled")
not_impl_err!(
"Unable to process an Avro PhysicalPlan when the `avro` feature is not enabled"
)
}

#[deprecated(
Expand Down
Loading