Skip to content

MSSQL: Support PROC as CREATE PROCEDURE abbreviation - #2448

Merged
LucaCappelletti94 merged 2 commits into
apache:mainfrom
t8y2:dev/mssql-create-proc
Sep 26, 2026
Merged

LucaCappelletti94 merged 2 commits into
apache:mainfrom
t8y2:dev/mssql-create-proc

Conversation

@t8y2

@t8y2 t8y2 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Adds support for the T-SQL PROC abbreviation in both CREATE PROC and CREATE OR ALTER PROC.

The parser gates the syntax through a dialect capability and normalizes the AST display to PROCEDURE. Tests also verify that CREATE PROC remains MSSQL-specific and that proc can still be used as an identifier.

Reference: https://learn.microsoft.com/en-us/sql/t-sql/statements/create-procedure-transact-sql

@LucaCappelletti94 LucaCappelletti94 added SQL Server needs rebasing The PR has collisions with main and requires rebasing labels Sep 22, 2026
@LucaCappelletti94 LucaCappelletti94 removed the needs rebasing The PR has collisions with main and requires rebasing label Sep 24, 2026
@codecov-commenter

codecov-commenter commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.09%. Comparing base (91f7ce2) to head (a3801e7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2448   +/-   ##
=======================================
  Coverage   81.09%   81.09%           
=======================================
  Files          42       42           
  Lines       33677    33684    +7     
  Branches    33677    33684    +7     
=======================================
+ Hits        27309    27316    +7     
  Misses       2798     2798           
  Partials     3570     3570           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94 LucaCappelletti94 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@t8y2 do consider reviewing some of the other open PRs, we'd really appreciate it!

cc @alamb @iffyio

@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Sep 26, 2026
Merged via the queue into apache:main with commit 560a13c Sep 26, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants