Doris SQL: add Doris Dialect by finchxxia · Pull Request #2380 · apache/datafusion-sqlparser-rs

finchxxia · 2026-06-17T08:25:09Z

Summary

Introduce DorisDialect as the first step toward Apache Doris support (#2379).
Previously, callers could not select a Doris dialect by name.

Register Doris in dialect lookup, the CLI example, and shared tests.
Delegate shared identifier, string, LIMIT, DIV, and GROUP BY behavior to MySQL.
Enable Doris nested block comments and add regression tests.
Include Doris in both fuzz targets and automatic dialect labeling.

CREATE TABLE extensions and load statements are left to follow-up PRs.

Reference: Doris lexer.

Validation

Passed all-feature tests, formatting, Clippy, labeler tests, and compilation checks for both fuzz targets.
Fuzzing was not run locally.

AI assistance was used for implementation and validation.

LucaCappelletti94 · 2026-06-17T10:33:54Z

2500 lines of a PR are a bit too many, could you fracture this down into smaller reviewable units?

finchxxia · 2026-06-18T02:43:57Z

2500 lines of a PR are a bit too many, could you fracture this down into smaller reviewable units?

@LucaCappelletti94 Of course, I would do that later and add more info in issue link #2379

finchxxia · 2026-07-03T06:09:33Z

2500 lines of a PR are a bit too many, could you fracture this down into smaller reviewable units?

@LucaCappelletti94 Done. Could you please take a look?

finchxxia · 2026-08-05T07:58:48Z

@alamb @benesch @LucaCappelletti94 Hi team, any improvement should I have?

LucaCappelletti94

This is the sort of PR that would really benefit from GitHub stabilizing stacked PR also for forks' branches. Let's hope that happens soon. In the meantime, here are a few notes on this first PR in the chain.

LucaCappelletti94 · 2026-08-05T08:32:44Z

+#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
+pub struct DorisDialect {}
+
+impl Dialect for DorisDialect {


I believe you are still currently missing:

supports_limit_comma

parse_infix (the DIV)

supports_group_by_with_modifier

I am not familiar enough with Doris to say anything about the other methods, but I suggest you audit them against the engine.

LucaCappelletti94 · 2026-08-05T08:34:22Z

+    }
+
+    fn is_identifier_start(&self, ch: char) -> bool {
+        ch.is_ascii_alphabetic() || ch == '_' || !ch.is_ascii()


Since these methods at this time are extensively identical and meant to be identical to the MySqlDialect, I suggest they are kept aligned by using the same approach used with redshift and postgres and dispatch the method call to MySqlDialect. When they are strictly distinct, a comment with a documentation link may be desirable.

LucaCappelletti94 · 2026-08-05T08:36:12Z

+}
+
+#[test]
+fn doris_identifier_and_string_literal_gates() {


I am unsure such a test is necessary

LucaCappelletti94 · 2026-08-05T08:36:49Z

+
+#[test]
+fn parse_doris_strings_and_identifiers() {
+    doris().verified_stmt(


I believe here you may want to use verified_only_select

LucaCappelletti94 · 2026-08-05T08:37:51Z

+
+#[test]
+fn doris_and_generic_parse_common_sql_identically() {
+    doris_and_generic().verified_stmt("SELECT 1 AS properties FROM t");


I imagine this will be more relevant in a later PR in this series where you add the keyword PROPERTIES?

I imagine this will be more relevant in a later PR in this series where you add the keyword PROPERTIES?

@LucaCappelletti94 sorry for the late reply. I've read all your comments here and try to improve these points. Could you take an another look plz?

…ESC / GET_DDL (apache#2380) * task LAV-1891: WIP — commit stranded agent work * task LAV-1891: WIP — commit stranded agent work * Task LAV-1891: emit queryContext + error positions for ALERT drop/desc/schedule/undrop

codecov-commenter · 2026-09-23T21:50:29Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.11%. Comparing base (560a13c) to head (d728af4).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2380      +/-   ##
==========================================
+ Coverage   81.09%   81.11%   +0.02%     
==========================================
  Files          42       43       +1     
  Lines       33684    33726      +42     
  Branches    33684    33726      +42     
==========================================
+ Hits        27316    27358      +42     
  Misses       2798     2798              
  Partials     3570     3570

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

LucaCappelletti94

You should trim the description to what this PR contains. It still lists CREATE TABLE models, LOAD DATA INFILE, CREATE ROUTINE LOAD and new AST structures, none of which are in this diff.

LucaCappelletti94 · 2026-09-24T07:59:58Z

+#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
+pub struct DorisDialect {}
+
+impl Dialect for DorisDialect {


You should also add DorisDialect to the dialect arrays in fuzz/fuzz_targets/fuzz_parse_sql.rs and fuzz/fuzz_targets/fuzz_parse_roundtrip.rs, and bump the [&dyn Dialect; 16] length. Without that, Doris is the only dialect that is never fuzzed.

LucaCappelletti94 · 2026-09-24T08:00:26Z

+#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
+pub struct DorisDialect {}
+
+impl Dialect for DorisDialect {


You should add a { label: "Doris", stems: ["doris"], pattern: /\bdoris\b/i } entry to DIALECTS in .github/workflows/labeler/label_dialects.js. Otherwise the follow-up PRs titled Doris: ... get no dialect label and the bot asks their author for one.

Co-authored-by: Luca Cappelletti <cappelletti.luca94@gmail.com>

finchxxia marked this pull request as draft June 17, 2026 08:28

finchxxia force-pushed the draft/doris-dialect-support branch from fc16163 to a55690c Compare June 17, 2026 08:35

finchxxia force-pushed the draft/doris-dialect-support branch from ecca2d6 to bffa3fd Compare June 18, 2026 05:21

This was referenced Jun 18, 2026

Doris SQL: create table model #2382

Closed

Doris SQL: create table column options #2383

Closed

finchxxia marked this pull request as ready for review June 18, 2026 06:15

Doris: Add dialect skeleton

7ff24be

finchxxia force-pushed the draft/doris-dialect-support branch from 8f0906f to 7ff24be Compare July 3, 2026 06:47

Merge branch 'main' into draft/doris-dialect-support

78c8b9c

LucaCappelletti94 requested changes Aug 5, 2026

View reviewed changes

finchxxia added 2 commits August 12, 2026 15:11

Doris: Delegate MySQL-compatible query syntax

d29d027

Doris: Refine dialect tests

3390f3f

finchxxia requested a review from LucaCappelletti94 August 13, 2026 05:14

tempusari mentioned this pull request Aug 25, 2026

Support of new Syntax #2082

Closed

Merge branch 'main' into draft/doris-dialect-support

cc99298

LucaCappelletti94 requested changes Sep 24, 2026

View reviewed changes

LucaCappelletti94 added the waiting on contributor The review needs further refinements by its author label Sep 24, 2026

finchxxia and others added 2 commits September 28, 2026 08:58

Update tests/sqlparser_doris.rs

282819b

Co-authored-by: Luca Cappelletti <cappelletti.luca94@gmail.com>

Update src/dialect/doris.rs

ca70ec2

Co-authored-by: Luca Cappelletti <cappelletti.luca94@gmail.com>

github-actions Bot added the MySQL label Sep 28, 2026

finchxxia added 2 commits September 28, 2026 09:13

chore: add Doris to fuzz test

e559954

Merge branch 'main' into draft/doris-dialect-support

d728af4

finchxxia requested a review from LucaCappelletti94 September 28, 2026 02:08

LucaCappelletti94 removed the waiting on contributor The review needs further refinements by its author label Sep 28, 2026

LucaCappelletti94 added the waiting on reviewer PR needs to be reviewed label Sep 28, 2026

Conversation

finchxxia commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Uh oh!

LucaCappelletti94 commented Jun 17, 2026

Uh oh!

finchxxia commented Jun 18, 2026

Uh oh!

finchxxia commented Jul 3, 2026

Uh oh!

finchxxia commented Aug 5, 2026

Uh oh!

LucaCappelletti94 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

LucaCappelletti94 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

finchxxia commented Jun 17, 2026 •

edited

Loading

codecov-commenter commented Sep 23, 2026 •

edited

Loading