`ORDER BY` parser

[Zizico2]

Would a specific ORDER BY parser fit into this crate? It would generate an iterator which yields Result<OrderByExpr, ParserError>. I have developed a rudimentary version of this, which I am using in production. I could further polish it and open a PR if this would be of interest. I am just repeatedly calling parse_order_by_expr and looking for EOF.

[AugustoFKL]

@Zizico2, but what would be the change? Could you please comment on some queries that you're expecting to work on that don't right now?

(sorry the delay, the last 2 months were a drag for me)

[Zizico2]

It wouldn't introduce any new functionality. It would only make it easier to parse a whole ORDER BY. Right now you can parse a single [column asc|desc]. If you want to parse a whole ORDER BY you have to manually walk through a string, look for commas, and parse every individual [column asc|desc]. Parsing a [[column asc|desc], [column asc|desc], [column asc|desc], [column asc|desc], [column asc|desc], ...], to me, seems common enough to have a built-in way of doing so.

[AugustoFKL]

Hmmm, TBH, I can't see any improvements. But if you think that's going to be more performative and/or efficient, feel free to do a PR!

I'll review it asap. Just please tag me when you do it, I'm not looking every single PR, but I want to look onto this.

[LucaCappelletti94]

Parser::parse_comma_separated and Parser::parse_order_by_expr are both public, so parser.parse_comma_separated(Parser::parse_order_by_expr) parses a whole ORDER BY list such as a ASC, b DESC NULLS FIRST, c, and parser.expect_token(&Token::EOF) checks nothing trails it. Closing as answered.