Skip to content

chore: Run tests with default ANSI flag #4841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
comphead wants to merge 3 commits into
base: main
Choose a base branch
from
+0 −21
Open

chore: Run tests with default ANSI flag #4841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48a8216
chore: Run agg tests with default ANSI flag
comphead Jul 6, 2026
aca5fe1
chore: Run agg tests with default ANSI flag
comphead Jul 6, 2026
9c97f18
chore: Run tests with default ANSI flag
comphead Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions spark/src/test/scala/org/apache/comet/CometCastSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import scala.jdk.CollectionConverters._
import scala.util.Random

import org.apache.hadoop.fs.Path
import org.apache.spark.SparkConf
import org.apache.spark.sql.{CometTestBase, DataFrame, Row, SaveMode}
import org.apache.spark.sql.catalyst.expressions.Cast
import org.apache.spark.sql.catalyst.parser.ParseException
Expand All @@ -43,11 +42,6 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {

import testImplicits._

// Casts in this suite predominantly test non-ANSI semantics (silent overflow/null on
// invalid input); tests that target ANSI behavior opt in explicitly via withSQLConf.
override protected def sparkConf: SparkConf =
super.sparkConf.set(SQLConf.ANSI_ENABLED.key, "false")

/** Create a data generator using a fixed seed so that tests are reproducible */
private val gen = DataGenerator.DEFAULT

Expand Down
9 changes: 0 additions & 9 deletions spark/src/test/scala/org/apache/comet/CometFuzzMathSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,10 @@

package org.apache.comet

import org.apache.spark.SparkConf
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.{DecimalType, IntegerType, LongType}

class CometFuzzMathSuite extends CometFuzzTestBase {

// The integer-math fuzz tests intentionally cover overflowing inputs; under Spark 4's
// default ANSI mode those would throw rather than produce a result for both Spark and
// Comet to compare against. Pin ANSI off so the parity comparison can run.
override protected def sparkConf: SparkConf =
super.sparkConf.set(SQLConf.ANSI_ENABLED.key, "false")

for (op <- Seq("+", "-", "*", "/", "div")) {
test(s"integer math: $op") {
val df = spark.read.parquet(filename)
Expand Down Expand Up @@ -63,5 +55,4 @@ class CometFuzzMathSuite extends CometFuzzTestBase {
checkSparkAnswerAndOperator(sql)
}
}

}
6 changes: 0 additions & 6 deletions spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ package org.apache.comet.exec
import scala.util.Random

import org.apache.hadoop.fs.Path
import org.apache.spark.SparkConf
import org.apache.spark.sql.{CometTestBase, DataFrame, Row}
import org.apache.spark.sql.catalyst.expressions.Cast
import org.apache.spark.sql.catalyst.optimizer.EliminateSorts
Expand All @@ -43,11 +42,6 @@ import org.apache.comet.testing.{DataGenOptions, FuzzDataGenerator, ParquetGener
class CometAggregateSuite extends CometTestBase with AdaptiveSparkPlanHelper {
import testImplicits._

// Several aggregate tests exercise overflow behavior expected to wrap around silently;
// ANSI-mode variants opt in to ANSI explicitly via withSQLConf.
override protected def sparkConf: SparkConf =
super.sparkConf.set(SQLConf.ANSI_ENABLED.key, "false")

test("min/max floating point with negative zero") {
val r = new Random(42)
val schema = StructType(
Expand Down
Loading