feat: Spark custom credential providers for native scans#4309
Draft
mbutrovich wants to merge 14 commits into
Draft
feat: Spark custom credential providers for native scans#4309mbutrovich wants to merge 14 commits into
mbutrovich wants to merge 14 commits into
Conversation
# Conflicts: # docs/source/contributor-guide/index.md
…entials for read vs. write
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Comet's native scan paths bypass Spark's Hadoop S3A credential infrastructure, so vendors with custom credential mechanisms (per-path STS, vended REST creds, etc.) can't use Comet on those paths. This PR adds a Java SPI vendors implement once, plus the JNI plumbing to call it from native code. Full justification in
docs/source/contributor-guide/cloud-credential-providers.md.What changes are included in this PR?
CometCloudCredentialProvider+ POJO +ServiceLoader-driven dispatcher incommonobject_store::CredentialProviderandreqsign_core::ProvideCredentialfor the same structs3.rs::create_store(Parquet/object_store path) andiceberg_scan.rs(Iceberg/opendal path)83b4595to pick up reqsign-core 3.0 / modernCustomAwsCredentialLoaderAPIHow are these changes tested?
ParquetReadFromS3Suite/IcebergReadFromS3Suiteupdated to pass with the bridge SPI globally registered on the test classpathdev/ci/check-suites.pyignore_list (manual, like the existing S3 suites)