CI: Add workflow to verify release candidate on multiple systems#4275
Open
kevinjqliu wants to merge 9 commits into
Open
CI: Add workflow to verify release candidate on multiple systems#4275kevinjqliu wants to merge 9 commits into
kevinjqliu wants to merge 9 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
kevinjqliu
commented
May 10, 2026
Comment on lines
+114
to
+116
| # Skip spotless since the source was already checked before release. | ||
| # Spotless can fail on Windows due to CRLF line ending differences. | ||
| ./mvnw verify -Prelease -DskipTests -P"spark-3.4" -Dmaven.gitcommitid.skip=true -Dspotless.check.skip=true |
Contributor
Author
There was a problem hiding this comment.
adds -Dspotless.check.skip=true here. The Spotless formatting plugin is failing due to line ending differences (LF in the tarball vs CRLF expected on Windows).
See https://github.com/kevinjqliu/datafusion-comet/actions/runs/25614322434/job/75189622764
| set -e | ||
| pushd native | ||
| RUSTFLAGS="-Ctarget-cpu=native" cargo build --release | ||
| cargo build --release ${COMET_CARGO_BUILD_ARGS:-} |
Contributor
Author
There was a problem hiding this comment.
RUSTFLAGS not needed here, removing it so that it can be overriden by env var in verify-release-candidate.yml
Contributor
Author
|
we can also add this workflow to the release instructions, similar to in datafusion-python https://github.com/apache/datafusion-python/pull/1388/files#diff-7b90af0d72004d8b923b4ed55f67a5f3e40e6a08ec9637f382d6506dd309848dR157-R174 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
This PR adds a manually triggered GitHub Actions workflow to verify release candidates across multiple OS/architecture combinations
Copied over from datafusion-python, https://github.com/kevinjqliu/datafusion-python/blob/baf4a7a47fc30cdb759ef7b7f9e5df6c38db8a57/.github/workflows/verify-release-candidate.yml
What changes are included in this PR?
How are these changes tested?
Ran manually on my fork, https://github.com/kevinjqliu/datafusion-comet/actions/runs/25614322434