Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
Contributor
|
@ACSHomeBot package G |
Packaging results:
Test packages are available at: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #14244.
Since 4.23 the binaries ISO ships the Headlamp dashboard as
headlamp.yamlinstead ofdashboard.yaml. The create path (k8s-control-node.yml) already falls back between the two,but
upgrade-kubernetes.shhardcodeddashboard.yaml. Because the script runs withbash -e,every upgrade using a Headlamp ISO failed on the first control node after kubeadm had already
upgraded it, leaving the cluster half-upgraded and in Alert.
This applies the same fallback as the create path:
headlamp.yaml, thendashboard.yaml,then a warning, so ISOs built before and after the Headlamp change both work.
Affects 4.23.0.0 and main. 4.22 is not affected. Happy to retarget if a 4.23 branch is
wanted for a patch release.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
How Has This Been Tested?
cluster, isolated network, .
v1.36.0, headlamp running in kube-system, cluster back to Running, version updated in DB.
error: the path "/mnt/k8sdisk//dashboard.yaml" does not exist.How did you try to break this feature and the system with this change?