Skip to content

CKS: support headlamp.yaml in upgrade-kubernetes.sh - #14245

Open
mw-0 wants to merge 1 commit into
apache:mainfrom
mw-0:patch-1
Open

mw-0 wants to merge 1 commit into
apache:mainfrom
mw-0:patch-1

Conversation

@mw-0

@mw-0 mw-0 commented Sep 24, 2026

Copy link
Copy Markdown

Description

This PR fixes #14244.

Since 4.23 the binaries ISO ships the Headlamp dashboard as headlamp.yaml instead of
dashboard.yaml. The create path (k8s-control-node.yml) already falls back between the two,
but upgrade-kubernetes.sh hardcoded dashboard.yaml. Because the script runs with bash -e,
every upgrade using a Headlamp ISO failed on the first control node after kubeadm had already
upgraded it, leaving the cluster half-upgraded and in Alert.

This applies the same fallback as the create path: headlamp.yaml, then dashboard.yaml,
then a warning, so ISOs built before and after the Headlamp change both work.

Affects 4.23.0.0 and main. 4.22 is not affected. Happy to retarget if a 4.23 branch is
wanted for a patch release.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • Major

How Has This Been Tested?

  • 4.23.0.0 management server with the patched script, single-control/single-worker CKS
    cluster, isolated network, .
  • Upgraded 1.35.8 -> 1.36.0 using a Headlamp-built ISO: upgrade completes, both nodes on
    v1.36.0, headlamp running in kube-system, cluster back to Running, version updated in DB.
  • Before the patch the same upgrade failed with
    error: the path "/mnt/k8sdisk//dashboard.yaml" does not exist.

How did you try to break this feature and the system with this change?

  • tried to upgrade using custom isos
  • Missing both files only logs a warning instead of failing the upgrade.### Description

@boring-cyborg

boring-cyborg Bot commented Sep 24, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

@andrijapanicsb

Copy link
Copy Markdown
Contributor

@ACSHomeBot package G

@ACSHomeBot

ACSHomeBot commented Sep 24, 2026 •

Copy link
Copy Markdown

Packaging results:

Result Artifact Platform
PASS RPM EL (EL8/9/10)
PASS DEB Ubuntu, Debian

Test packages are available at:

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CKS: upgradeKubernetesCluster fails on control node when binaries ISO ships headlamp.yaml instead of dashboard.yaml

3 participants