CLVM enhancements and fixes by Pearl1594 · Pull Request #12617 · apache/cloudstack

Pearl1594 · 2026-02-09T19:47:40Z

Description

This PR enhances the existing CLVM implementation which was based on the deprecated CLVM technology which was based on corosync/pacemaker. With RHEL 7 having reached EOL, CLVM seems to be broken. CLVM supports RAW volumes on LVM , where as CLVM_NG support QCOW2 on LVM.

Further details: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Modernized+CLVM%3A+Enhancements+and+CLVM_NG+support

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2026-02-09T20:01:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.68%. Comparing base (d3e1976) to head (df61d6f).
⚠️ Report is 15 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (d3e1976) and HEAD (df61d6f). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (d3e1976) HEAD (df61d6f)

unittests 1 0

Additional details and impacted files

@@              Coverage Diff              @@
##               main   #12617       +/-   ##
=============================================
- Coverage     17.90%    3.68%   -14.23%     
=============================================
  Files          5938      454     -5484     
  Lines        532864    38798   -494066     
  Branches      65192     7151    -58041     
=============================================
- Hits          95392     1428    -93964     
+ Misses       426793    37183   -389610     
+ Partials      10679      187    -10492

Flag	Coverage Δ
uitests	`3.67% <ø> (+<0.01%)`	⬆️
unittests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…of running vm

Pearl1594 · 2026-02-11T19:43:29Z

@blueorangutan package

blueorangutan · 2026-02-11T19:44:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-11T20:28:42Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16801

weizhouapache · 2026-02-17T15:02:13Z

        UserVmVO vm = userVmDao.findById(vmId);
        String cantHandleLog = String.format("Default VM snapshot cannot handle VM snapshot for [%s]", vm);
+
+        if (isRunningVMVolumeOnCLVMStorage(vm, cantHandleLog)) {


@Pearl1594
what's the image format on CLVM ? RAW or QCOW2 ?

RAW @weizhouapache

codecov · 2026-02-17T15:24:41Z

Codecov Report

❌ Patch coverage is 43.16823% with 1331 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.21%. Comparing base (a4a52c9) to head (4584cb8).

Files with missing lines	Patch %	Lines
...oud/hypervisor/kvm/storage/ClvmStorageAdaptor.java	36.26%	436 Missing and 14 partials ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	44.00%	135 Missing and 5 partials ⚠️
...stack/engine/orchestration/VolumeOrchestrator.java	23.46%	73 Missing and 2 partials ⚠️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	30.52%	62 Missing and 4 partials ⚠️
...tack/storage/endpoint/DefaultEndPointSelector.java	50.40%	43 Missing and 19 partials ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java	57.04%	53 Missing and 8 partials ⚠️
...resource/wrapper/LibvirtMigrateCommandWrapper.java	13.23%	52 Missing and 7 partials ⚠️
...wrapper/LibvirtClvmLockTransferCommandWrapper.java	37.63%	52 Missing and 6 partials ⚠️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java	17.85%	46 Missing ⚠️
...n/java/com/cloud/storage/clvm/ClvmPoolManager.java	73.52%	27 Missing and 18 partials ⚠️
... and 28 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12617      +/-   ##
============================================
+ Coverage     18.08%   18.21%   +0.12%     
- Complexity    16721    16949     +228     
============================================
  Files          6037     6047      +10     
  Lines        542580   544819    +2239     
  Branches      66428    66792     +364     
============================================
+ Hits          98149    99216    +1067     
- Misses       433409   434480    +1071     
- Partials      11022    11123     +101

Flag	Coverage Δ
uitests	`3.51% <ø> (-0.01%)`	⬇️
unittests	`19.38% <43.16%> (+0.12%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Pearl1594 · 2026-02-18T16:33:12Z

@blueorangutan package

blueorangutan · 2026-02-18T16:40:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-18T17:32:01Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16875

Pearl1594 · 2026-02-18T20:23:11Z

@blueorangutan package

blueorangutan · 2026-02-18T20:24:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-18T21:16:21Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16877

…ached volumes

blueorangutan · 2026-05-07T18:53:57Z

[SF] Trillian test result (tid-16033)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 89277 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12617-t16033-kvm-ol8.zip
Smoke tests completed. 136 look OK, 15 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_CRUD_operations_userdata	`Error`	1522.70	test_register_userdata.py
test_deploy_vm_with_registered_userdata	`Error`	6.30	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow	`Error`	6.86	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append	`Error`	6.50	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_deny	`Error`	6.19	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params	`Error`	6.23	test_register_userdata.py
test_link_and_unlink_userdata_to_template	`Error`	6.36	test_register_userdata.py
test_user_userdata_crud	`Error`	11.52	test_register_userdata.py
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup	`Error`	0.00	test_resource_accounting.py
test_03_register_template	`Error`	1.15	test_resource_names.py
ContextSuite context=TestRestoreVM>:setup	`Error`	0.00	test_restore_vm.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup	`Error`	0.00	test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup	`Error`	0.00	test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup	`Error`	0.00	test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	0.32	test_service_offerings.py
ContextSuite context=TestSetSourceNatIp>:setup	`Error`	0.00	test_set_sourcenat.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestSslOffloading>:setup	`Error`	0.00	test_ssl_offloading.py

Pearl1594 · 2026-05-07T18:57:57Z

@blueorangutan test

blueorangutan · 2026-05-07T19:00:04Z

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-05-08T09:37:03Z

[SF] Trillian test result (tid-16043)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49742 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12617-t16043-kvm-ol8.zip
Smoke tests completed. 151 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

github-actions · 2026-05-08T15:31:26Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

…-enhancements

Pearl1594 · 2026-05-08T15:59:54Z

@blueorangutan package

blueorangutan · 2026-05-08T16:02:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-08T16:50:44Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17793

Pearl1594 · 2026-05-08T18:48:26Z

@blueorangutan package

blueorangutan · 2026-05-08T18:50:05Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-08T19:38:20Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17795

Pearl1594 · 2026-05-08T20:02:05Z

@blueorangutan test

blueorangutan · 2026-05-08T20:04:04Z

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-05-09T14:14:30Z

[SF] Trillian test result (tid-16059)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 62610 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12617-t16059-kvm-ol8.zip
Smoke tests completed. 150 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestAccounts>:setup	`Error`	0.00	test_accounts.py
ContextSuite context=TestAddVmToSubDomain>:setup	`Error`	0.00	test_accounts.py
test_DeleteDomain	`Error`	9.82	test_accounts.py
test_forceDeleteDomain	`Failure`	9.73	test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup	`Error`	10.68	test_accounts.py
ContextSuite context=TestTemplateHierarchy>:setup	`Error`	1530.37	test_accounts.py

Pearl1594 · 2026-05-10T22:43:38Z

@blueorangutan package

blueorangutan · 2026-05-10T22:44:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-10T22:58:56Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 17805

Pearl1594 · 2026-05-10T23:10:37Z

@blueorangutan package

blueorangutan · 2026-05-10T23:12:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-10T23:57:34Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17806

Pearl1594 · 2026-05-10T23:59:48Z

@blueorangutan test

blueorangutan · 2026-05-11T00:02:04Z

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

sonarqubecloud · 2026-05-11T02:02:44Z

Quality Gate failed

Failed conditions
1 Security Hotspot
33.1% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

boring-cyborg Bot added component:kvm component:storage labels Feb 9, 2026

CLVM enhancements and fixes

9e03f4b

Pearl1594 force-pushed the clvm-enhancements branch from 5fc1f12 to 9e03f4b Compare February 9, 2026 21:39

Pearl1594 added 2 commits February 10, 2026 19:48

add support for proper cleanup of snapshots and prevent vol snapshot …

96edadc

…of running vm

remove snap vol restriction for sunning vms

f9d8062

harikrishna-patnala added this to the 4.23.0 milestone Feb 17, 2026

weizhouapache reviewed Feb 17, 2026

View reviewed changes

Pearl1594 force-pushed the clvm-enhancements branch from a08e7a5 to df61d6f Compare February 17, 2026 15:04

refactor clvm code

43e9384

Pearl1594 force-pushed the clvm-enhancements branch from df61d6f to 43e9384 Compare February 17, 2026 15:16

boring-cyborg Bot added component:api component:compute component:orchestration labels Feb 17, 2026

add support for live migration

c9dd7ed

Pearl1594 force-pushed the clvm-enhancements branch from 3f900e8 to c9dd7ed Compare February 17, 2026 22:54

add support for migrating lvm lock

4984ee5

Pearl1594 added 2 commits February 19, 2026 15:42

clvm deletion called explicitly

190b201

made necessary changes to allow migration of lock and deletion of det…

8a7e48a

…ached volumes

github-actions Bot added the status:has-conflicts label May 8, 2026

Merge branch 'main' of https://github.com/apache/cloudstack into clvm…

1111225

…-enhancements

bypass host maintainance

bcabdaf

made few improvements in selecting host

36827a9

fix build

4584cb8

Pearl1594 closed this May 11, 2026

Pearl1594 reopened this May 11, 2026

Conversation

Pearl1594 commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov Bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pearl1594 commented Feb 11, 2026

Uh oh!

blueorangutan commented Feb 11, 2026

Uh oh!

blueorangutan commented Feb 11, 2026

Uh oh!

weizhouapache Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Pearl1594 Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pearl1594 commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

Pearl1594 commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

blueorangutan commented May 7, 2026

Uh oh!

Pearl1594 commented May 7, 2026

Uh oh!

blueorangutan commented May 7, 2026

Uh oh!

blueorangutan commented May 8, 2026

Uh oh!

github-actions Bot commented May 8, 2026

Uh oh!

Pearl1594 commented May 8, 2026

Uh oh!

blueorangutan commented May 8, 2026

Uh oh!

blueorangutan commented May 8, 2026

Uh oh!

Pearl1594 commented May 8, 2026

Uh oh!

blueorangutan commented May 8, 2026

Uh oh!

blueorangutan commented May 8, 2026

Uh oh!

Pearl1594 commented May 8, 2026

Uh oh!

blueorangutan commented May 8, 2026

Uh oh!

blueorangutan commented May 9, 2026

Uh oh!

Pearl1594 commented May 10, 2026

Uh oh!

blueorangutan commented May 10, 2026

Uh oh!

blueorangutan commented May 10, 2026

Uh oh!

Pearl1594 commented May 10, 2026

Uh oh!

Pearl1594 commented Feb 9, 2026 •

edited

Loading

codecov Bot commented Feb 9, 2026 •

edited

Loading

codecov Bot commented Feb 17, 2026 •

edited

Loading