NOTICE: add the original gpbackup NOTICE#102
Merged
Merged
Conversation
leborchuk
approved these changes
Jun 11, 2026
leborchuk
left a comment
There was a problem hiding this comment.
Yes, it is instructed to add NOTICE info about copyrights if it was removed. And we could have a single NOTICE file, not to copy multiple files
Copyright notifications which have been [relocated](https://www.apache.org/legal/src-headers.html#headers), rather than removed, from source files must be preserved in NOTICE. However, elements such as the copyright notifications embedded within BSD and MIT licenses [do not need to be duplicated](https://issues.apache.org/jira/browse/LEGAL-59) in NOTICE. You can leave those notices in their original locations.
In our 2.1.0-rc2 review round, Jean Baptiste Onofre suggested we can include the original gpbackup NOTICE file content to the NOTICE. I also check the ASF docs, and find that we should do as the suggestion. You can see more details here: - https://lists.apache.org/thread/s3r9zmkt90cjnx8921mvmojw2zdfgh8k - https://infra.apache.org/licensing-howto.html#mod-notice
a20a028 to
0de2779
Compare
tuhaihe
added a commit
to apache/cloudberry-pxf
that referenced
this pull request
Jun 11, 2026
For Apache license files, we need to keep the original NOTICE file content if there is one. Seem as apache/cloudberry-backup#102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our 2.1.0-rc2 review round, Jean Baptiste Onofre suggested we can include the original gpbackup NOTICE file content to the NOTICE. I also check the ASF docs, and find that we should do as the suggestion.
You can see more details here:
closes: #ISSUE_Number
Change logs
Contributor's checklist
Here are some reminders before you submit your pull request: