Skip to content

NOTICE: add the original gpbackup NOTICE#102

Merged
tuhaihe merged 1 commit into
apache:mainfrom
tuhaihe:update-notice-06
Jun 12, 2026
Merged

NOTICE: add the original gpbackup NOTICE#102
tuhaihe merged 1 commit into
apache:mainfrom
tuhaihe:update-notice-06

Conversation

@tuhaihe

@tuhaihe tuhaihe commented Jun 11, 2026

Copy link
Copy Markdown
Member

In our 2.1.0-rc2 review round, Jean Baptiste Onofre suggested we can include the original gpbackup NOTICE file content to the NOTICE. I also check the ASF docs, and find that we should do as the suggestion.

You can see more details here:

closes: #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what document is being added or updated.

Contributor's checklist

Here are some reminders before you submit your pull request:

@leborchuk leborchuk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is instructed to add NOTICE info about copyrights if it was removed. And we could have a single NOTICE file, not to copy multiple files

Copyright notifications which have been [relocated](https://www.apache.org/legal/src-headers.html#headers), rather than removed, from source files must be preserved in NOTICE. However, elements such as the copyright notifications embedded within BSD and MIT licenses [do not need to be duplicated](https://issues.apache.org/jira/browse/LEGAL-59) in NOTICE. You can leave those notices in their original locations.

In our 2.1.0-rc2 review round, Jean Baptiste Onofre suggested we can
include the original gpbackup NOTICE file content to the NOTICE. I also
check the ASF docs, and find that we should do as the suggestion.

You can see more details here:
- https://lists.apache.org/thread/s3r9zmkt90cjnx8921mvmojw2zdfgh8k
- https://infra.apache.org/licensing-howto.html#mod-notice
@tuhaihe tuhaihe force-pushed the update-notice-06 branch from a20a028 to 0de2779 Compare June 11, 2026 14:33
tuhaihe added a commit to apache/cloudberry-pxf that referenced this pull request Jun 11, 2026
For Apache license files, we need to keep the original NOTICE file
content if there is one.

Seem as apache/cloudberry-backup#102
@tuhaihe tuhaihe merged commit cffa009 into apache:main Jun 12, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants