ARTEMIS-5972: Replace JNI with Panama Foreign Function & Memory (FFM)…#6444
ARTEMIS-5972: Replace JNI with Panama Foreign Function & Memory (FFM)…#6444mayankkunwar wants to merge 1 commit into
Conversation
|
nice one @mayankkunwar |
mayankkunwar
force-pushed
the
ARTEMIS-5972
branch
2 times, most recently
from
17ca830 to
758dfd6
Compare
| <module>artemis-lockmanager</module> | ||
| <module>artemis-image</module> | ||
| <module>artemis-image/examples</module> | ||
| <module>artemis-ffm</module> |
There was a problem hiding this comment.
<module>artemis-ffm</module> Isn't really a useful name for the module, it doesn't really describe what the module is used for or help someone identify what functionality this might include. Probably should indicate is a libaio module "artemis-libaio' or some such as the FFM bits is the implementation part of what its doing, not what it does.
There was a problem hiding this comment.
@tabish121 we could add other libraries that are using ffm later. Mayank is doing some experimentation with ioUring... we could add that into this module if it gets any useful.
Not that I foresee many other libraries in the future.. but what if we ever add more?
I didn't want to use the word native as native itself is a reserved name in java, and to not confuse with the current JNI implementation.
mayankkunwar
force-pushed
the
ARTEMIS-5972
branch
8 times, most recently
from
a91e37f to
f177963
Compare
mayankkunwar
force-pushed
the
ARTEMIS-5972
branch
from
f177963 to
68f5845
Compare
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | ||
|
|
||
| <maven.compiler.source>22</maven.compiler.source> |
There was a problem hiding this comment.
these are specified in the parent pom, right? can we remove these?
There was a problem hiding this comment.
In the parent pom the defined version is 17, but the FFM part needs 22 to be defined. So we need this here until parent is defined as 22 or later
| @Fork(value = 2) | ||
| @Warmup(iterations = 5, time = 200, timeUnit = TimeUnit.MILLISECONDS) | ||
| @Measurement(iterations = 10, time = 200, timeUnit = TimeUnit.MILLISECONDS) | ||
| public class AioCompareBenchmark { |
There was a problem hiding this comment.
We can merge this here initially.. but I will move these to the performance-jmh module, after merged.
|
|
||
| try { | ||
| // fillHeader(fileId); | ||
| // libaioFile.write(0L, BLOCK_SIZE, headerBuffer, callback); |
There was a problem hiding this comment.
can we remove commented out code ? I don't think this is needed.
… API for Journal Native Layer
mayankkunwar
force-pushed
the
ARTEMIS-5972
branch
from
68f5845 to
fb9503f
Compare
3 participants
… API for Journal Native Layer