Repository navigation
Conversation
github-actions
Bot
added
Component: R
awaiting committer review
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Native wrapping can still abort R, and nested conversions can lose nulls or produce inconsistent element types.
3 open issues
What changed in this PR
Addresses GH-53951 by allowing R bindings to handle extension types defined outside R without unsafe casts.
Changes:
- Adds native-type detection and R class/string fallbacks.
- Converts non-R extension arrays through their storage types.
- Adds regression coverage for native types, slices, chunks, and nested columns.
| File | Description |
|---|---|
| r/tests/testthat/test-extension.R | Tests native extension handling and conversion. |
| r/src/extension-impl.cpp | Guards casts and detects R-defined types. |
| r/src/arrowExports.cpp | Registers the new native helper. |
| r/src/array_to_vector.cpp | Adds storage-based conversion fallback. |
| r/R/extension.R | Handles native class dispatch and formatting. |
| r/R/arrowExports.R | Exposes the type-detection helper to R. |
Review effort: Balanced
| # Not created from R (e.g., a canonical extension type registered by | ||
| # libarrow such as arrow.uuid), so there is no R6 subclass to | ||
| # dispatch to: fall back to this class | ||
| ExtensionType |
| // such as arrow.uuid registered by libarrow itself), so there is no R-level | ||
| // as_vector() to call: convert the storage arrays instead, which is what | ||
| // the default ExtensionType$as_vector() does. | ||
| return ConvertStorage(); |
| extension_type.storage_type()); | ||
| // The outer conversion's task group isn't reachable from Allocate(), so the | ||
| // storage is converted serially here, as RExtensionType::Convert() does | ||
| return Converter::Convert(storage, false); |
thisisnic
marked this pull request as draft
October 18, 2026 17:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Creating non instances of non-R extension types segfaulted
What changes are included in this PR?
Plumb in machinery to allow non-R extension types, including using the right kind of pointer
Are these changes tested?
Yup
Are there any user-facing changes?
Nah
Was AI used for this PR?
Used AI to generate code, asked lots of questions. Also manually ran code before/after to confirm segfault with the code but no segfault without it.
PR code and description written by:
Reviewed before submission by: