Skip to content

MINOR: [C++][Engine] Validate Substrait emit output_mapping indices #53521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nayana-Naik73 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MINOR: [C++][Engine] Validate Substrait emit output_mapping indices #53521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cpp/src/arrow/engine/substrait/relation_internal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ Result<EmitInfo> GetEmitInfo(const RelMessage& rel,
FieldVector emit_fields(emit_size);
for (int i = 0; i < emit_size; i++) {
int32_t map_id = emit.output_mapping(i);
if (map_id < 0 || map_id >= input_schema->num_fields()) {
return Status::Invalid("Out of bounds emit index ", map_id);
}
proj_field_refs[i] = compute::field_ref(FieldRef(map_id));
emit_fields[i] = input_schema->field(map_id);
}
Expand All @@ -111,6 +114,9 @@ Result<DeclarationInfo> ProcessEmitProject(
std::vector<compute::Expression> emit_proj_exprs(emit_size);
for (int i = 0; i < emit_size; i++) {
int32_t map_id = emit.output_mapping(i);
if (map_id < 0 || map_id >= input_schema->num_fields()) {
return Status::Invalid("Out of bounds emit index ", map_id);
}
emit_fields[i] = input_schema->field(map_id);
emit_proj_exprs[i] = std::move(proj_options.expressions[map_id]);
}
Expand Down
Loading