chore: speed up miri workflow & include arrow-cmp - #10580
Open
Jefffrey wants to merge 4 commits into
Open
Conversation
Jefffrey
changed the title
Contributor
Author
|
looks like 20 minutes now |
Jefffrey
marked this pull request as ready for review
August 7, 2026 13:06
Contributor
It is 20 minutes but with 6 executors (so a total CPU time of 120 min / 2 hours) 🤔 
However, that appears to me what the current main uses too (just in 4 parallel runs) 
Maybe we should consider reducing MIRI on PRs (and only run it on merge to main) 🤔 |
Contributor
Author
|
yeah was mainly interested in reducing the workflow time, even though total cpu time takes the same amount
one thing to consider with this is if new tests are added, they could have issues such as taking too long to run or miri not supporting them (e.g. hits asm), so ideally we'd wanna still catch those during PR instead of fixing after the fact on main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before #10507 (running miri on more crates), miri took about 15-20 minutes on average. with the new PR it increased to a bit over 30 minutes because we're running more tests.
increase the partitions count to try get average runtime down, also use taiki-e to install nextest via binary to shave off 3 minutes spent on compiling nextest from source.
also include arrow-cmp (new crate) in the miri execution