Repository navigation
fix(python): Support iterating map arrays as Python objects - #998
Draft
edgarrmondragon wants to merge 1 commit into
Draft
edgarrmondragon wants to merge 1 commit into
edgarrmondragon wants to merge 1 commit into
Conversation
Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
edgarrmondragon
force-pushed
the
feat/map
branch
from
October 26, 2026 18:10
6ffc8f4 to
ee6bb2d
Compare
paleolimbot
reviewed
Oct 28, 2026
paleolimbot
left a comment
Member
There was a problem hiding this comment.
Thank you!
Just one correctness issue I think. I appreciate the contribution!
Comment on lines
+290
to
+293
| starts = offsets[:-1] | ||
| ends = offsets[1:] | ||
| entries = self._children[0] | ||
| entries_iter = entries._struct_tuple_iter(starts[0], ends[-1] - starts[0]) |
Member
There was a problem hiding this comment.
I believe here we have to handle the zero length case first (before indexing into the entries)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for iterating map arrays:
Run it with
uv run --no-project mre_map.py. The output is: