Fix crash when tailing logs of a running task instance#69503
Merged
jason810496 merged 1 commit intoJul 7, 2026
Conversation
FileTaskHandler._read() returns an itertools.islice stream when resuming a log read via metadata["log_pos"] (introduced in apache#63531), but _is_logs_stream_like() only recognized chain and generator objects, so the public read() wrapper raised TypeError: Invalid log stream type... Got islice instead whenever a client polled or tailed a running task's logs.
phanikumv
approved these changes
Jul 7, 2026
Member
Author
|
I forgot to add the |
jason810496
added a commit
to jason810496/airflow
that referenced
this pull request
Jul 7, 2026
…pache#69503) FileTaskHandler._read() returns an itertools.islice stream when resuming a log read via metadata["log_pos"] (introduced in apache#63531), but _is_logs_stream_like() only recognized chain and generator objects, so the public read() wrapper raised TypeError: Invalid log stream type... Got islice instead whenever a client polled or tailed a running task's logs. (cherry picked from commit 87089a5) Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
FileTaskHandler.read()raisesTypeError: Invalid log stream type... Got islice insteadwhenever a client polls/tails the logs of a running task (any read after the first, i.e.metadata["log_pos"]is set) — a regression from #63531 in released Airflow 3.2.2._read()to correctly reassignout_stream = islice(out_stream, metadata["log_pos"], None), but that changedout_stream's runtime type fromGeneratorTypetoitertools.islice.read()wrapper dispatches on_is_logs_stream_like(), which only recognizedchain/GeneratorType— notislice— so it fell through every branch and raisedTypeError.What
isliceto_is_logs_stream_like'sisinstancetuple.Iteratorwithisinstanceas the purpose of_is_logs_stream_likeis distinguishing whether the given "iterator" log source is coming "from stream interface" or not,Iteratoris too board.Was generative AI tooling used to co-author this PR?