Fix Microsoft WinRM provider import failure under lowest dependencies#69333
Merged
Conversation
pywinrm imports `spnego.ContextProxy`, which pyspnego only exposes from version 0.4.0 onwards. The winrm provider only declared `pywinrm>=0.5.0` and left pyspnego unbounded, so lowest-dependency resolution selected a pre-0.4.0 pyspnego and the provider failed at import time with `module 'spnego' has no attribute 'ContextProxy'`, breaking the LowestDeps CI job. Flooring pyspnego directly keeps the lowest-dependency resolution on a version that actually provides the attribute pywinrm needs.
shahar1
approved these changes
Jul 3, 2026
75 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Microsoft WinRM provider declared only
pywinrm>=0.5.0and leftpyspnego(a transitive dependency of pywinrm) unbounded.
pywinrmimportsspnego.ContextProxy, whichpyspnegoonly exposes from version0.4.0onwards, so lowest-dependency resolution selected a pre-
0.4.0pyspnegoandthe provider failed at import time with
module 'spnego' has no attribute 'ContextProxy'— breaking theLowestDepsproviders CI job.
Flooring
pyspnego>=0.4.0directly in the provider keeps lowest-dependencyresolution on a version that actually provides the attribute
pywinrmneeds.The gap is pre-existing on
main(surfaced by the failingLowestDepsshard onPR #64643, which is unrelated to that PR's Samba change).
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines